Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Swagger to 1.2.3 #92

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Dec 16, 2020

https://app.swaggerhub.com/apis-docs/bharvest/cosmos-sdk_liquidity_module_rest_and_g_rpc_gateway_docs/1.2.3

  • deprecate legacy tx endpoint
    According to this document, the POST endpoints of the New gGPC-gateway REST are N/A and guided directly to use Protobuf, so we will also deprecate the POST endpoints of the liquidity module.

  • added description and example

  • liquidity_pools_response → pools

  • liquidity_pool_meta_data → liquidity_pool_metadata

  • deposit_msgs[i].Msg → deposits[i].msg

  • succeed to succeeded

  • to_delete to to_be_deleted

  • swap_msgs → swaps

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #92 (fb94934) into develop (6202279) will not change coverage.
The diff coverage is 84.28%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #92   +/-   ##
========================================
  Coverage    80.33%   80.33%           
========================================
  Files           18       18           
  Lines         1836     1836           
========================================
  Hits          1475     1475           
  Misses         192      192           
  Partials       169      169           
Impacted Files Coverage Δ
x/liquidity/keeper/genesis.go 71.42% <0.00%> (ø)
x/liquidity/types/params.go 82.71% <50.00%> (ø)
x/liquidity/types/swap.go 86.56% <50.00%> (ø)
x/liquidity/keeper/liquidity_pool.go 70.08% <85.71%> (ø)
x/liquidity/keeper/batch.go 77.60% <100.00%> (ø)
x/liquidity/keeper/store.go 89.24% <100.00%> (ø)
x/liquidity/keeper/swap.go 76.74% <100.00%> (ø)
x/liquidity/types/liquidity_pool.go 83.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6202279...fb94934. Read the comment docs.

@dongsam dongsam marked this pull request as ready for review December 16, 2020 18:01
@dongsam dongsam merged commit ba15d26 into tendermint:develop Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant