Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty, incorrect pool cases #91

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Dec 10, 2020

Fix Depositing to an empty pool results in consensus failure #89
and Trying to buy tokens from an incorrect pool results in chain halting #90 cases

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #91 (52caf9d) into develop (527ea2e) will decrease coverage by 0.14%.
The diff coverage is 71.64%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #91      +/-   ##
===========================================
- Coverage    80.47%   80.33%   -0.15%     
===========================================
  Files           18       18              
  Lines         1798     1836      +38     
===========================================
+ Hits          1447     1475      +28     
- Misses         187      192       +5     
- Partials       164      169       +5     
Impacted Files Coverage Δ
x/liquidity/keeper/liquidity_pool.go 70.08% <71.64%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527ea2e...52caf9d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant