Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disable codecov on patch case that causes some wrong results #451

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: disable codecov on patch case that causes some wrong results #451

wants to merge 1 commit into from

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Oct 6, 2021

Description

closes: #449

Tasks

  • Add .codecov.yml file and disable codecov on patch

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz self-assigned this Oct 6, 2021
@dongsam dongsam changed the title feat: disable codecov on patch feat: disable codecov on patch case that causes some wrong results Oct 7, 2021
@jaybxyz jaybxyz marked this pull request as ready for review October 7, 2021 07:38
@jaybxyz jaybxyz requested a review from dongsam October 7, 2021 07:38
dongsam
dongsam reviewed Oct 7, 2021
View reviewed changes
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see if there's any wrong result also in the #446 and decide whether to merge this PR.

@dongsam dongsam mentioned this pull request Oct 12, 2021
Merged
14 tasks
@dongsam dongsam added the wontfix This will not be worked on label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongsam dongsam dongsam left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jaybxyz jaybxyz

Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: disable codecov on patch case that causes some wrong results
2 participants
@jaybxyz @dongsam