Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide where to use Quo/MulTruncate and where to use Quo/Mul #380

Closed
hallazzang opened this issue Jun 1, 2021 · 0 comments · Fixed by #413
Closed

Decide where to use Quo/MulTruncate and where to use Quo/Mul #380

hallazzang opened this issue Jun 1, 2021 · 0 comments · Fixed by #413
Assignees
@hallazzang
Labels
enhancement New feature or request
Milestone
Milestone 2: Laun...

Comments

@hallazzang
Copy link
Contributor

During the calculations we use sdk.Dec.Quo and sdk.Dec.Mul extensively, but there are also sdk.Dec.QuoTruncate and sdk.Dec.MulTruncate.
We need to determine which methods suit better for which situation.
@hallazzang hallazzang added the enhancement New feature or request label Jun 1, 2021
hallazzang added a commit to b-harvest/liquidity that referenced this issue Jun 2, 2021
@hallazzang
rollback change of Quo/MulTruncate to Quo/Mul
c391959 
this should be done in tendermint#380
dongsam pushed a commit that referenced this issue Jun 3, 2021
@hallazzang
Change the logic to determine if the pool was depleted (#369)
5f19607 
* keep zero reserve coins from GetReserveCoins

* treat pool with zero pool coin supply as depleted

also change Mul/QuoTruncate to Mul/Quo.

fixes #364

* rollback change of Quo/MulTruncate to Quo/Mul

this should be done in #380
dongsam pushed a commit that referenced this issue Jun 8, 2021
@hallazzang
Treat a pool with zero reserve coin as depleted (#394)
e8ab2f4 
* keep zero reserve coins from GetReserveCoins

* treat pool with zero pool coin supply as depleted

also change Mul/QuoTruncate to Mul/Quo.

fixes #364

* rollback change of Quo/MulTruncate to Quo/Mul

this should be done in #380

* treat a pool with zero reserve coin as depleted
@hallazzang hallazzang mentioned this issue Jun 14, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hallazzang hallazzang

Labels
enhancement New feature or request
Projects
None yet
Milestone
Milestone 2: Launch Gravity DEX v1 on...
Development

Successfully merging a pull request may close this issue.

Correct usage of Mul/Quo and Mul/QuoTruncate b-harvest/liquidity
2 participants
@dongsam @hallazzang