Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the initial epoch to 1 #205

Merged
merged 4 commits into from
Nov 4, 2021

Conversation

hallazzang
Copy link
Contributor

Description

See #192 for details

few more changes:

  • automatically initialize and prune info about a staking coin denom
  • do not automatically delete outstanding rewards when decreasing it
  • adjust tests

closes: #192


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

see tendermint#192 for details

few more changes:
- automatically initialize and prune info about a staking coin denom
- do not automatically delete outstanding rewards when decreasing it
- adjust tests
@hallazzang hallazzang requested review from dongsam and jaybxyz November 2, 2021 16:53
@hallazzang hallazzang self-assigned this Nov 2, 2021
x/farming/keeper/staking.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hallazzang hallazzang requested review from dongsam and jaybxyz November 3, 2021 14:04
@hallazzang hallazzang merged commit ec4d5f5 into tendermint:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: change the initial epoch to 1
3 participants