Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply suggestions from the audit review #202

Merged
merged 11 commits into from
Nov 10, 2021

Conversation

hallazzang
Copy link
Contributor

@hallazzang hallazzang commented Oct 27, 2021

Description

Apply suggestions from the audit review(#190).

Tasks

  • Delete terminated plans (discussing)
  • Simplify plan creation fee check
  • Add inline documentation for k.AllocationInfos, k.AllocateRewards
  • Rename coins to planCoins for clear meaning
  • Remove duplicated SetModuleAccount

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@hallazzang hallazzang self-assigned this Oct 27, 2021
@hallazzang hallazzang marked this pull request as ready for review November 3, 2021 06:23
@dongsam dongsam mentioned this pull request Nov 3, 2021
9 tasks
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsam dongsam added this to the Farming F1 v1.0 milestone Nov 3, 2021
@dongsam dongsam added the enhancement New feature or request label Nov 3, 2021
x/farming/keeper/reward.go Outdated Show resolved Hide resolved
x/farming/keeper/reward.go Outdated Show resolved Hide resolved
@dongsam dongsam merged commit 85ac9ee into tendermint:main Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants