Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: edit farming spec to improve documentation quality (part of #172) #191

Merged
merged 3 commits into from
Oct 27, 2021

Conversation

barriebyron
Copy link
Contributor

Description

edit farming spec to improve documentation quality #172
(this is a recovery PR: the original work was done in #188 but Barrie overwrite the changes, so getting fresh PR to capture all of the edits)

part of #172

Tasks

  • [ ]

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@barriebyron barriebyron requested a review from jaybxyz October 25, 2021 20:54
@barriebyron barriebyron self-assigned this Oct 25, 2021
@barriebyron barriebyron changed the title Farming spec fix docs: edit farming spec to improve documentation quality (part of #172) Oct 25, 2021
Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As far as I can tell, nothing is merged to master branch at this moment. So I believe we can ignore the #188?

@jaybxyz jaybxyz requested a review from dongsam October 26, 2021 02:39
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@barriebyron barriebyron merged commit 25fa703 into main Oct 27, 2021
@barriebyron barriebyron deleted the farming-spec-fix branch October 27, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants