Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create CODEOWNERS file and update contributing.md #189

Merged
merged 3 commits into from
Oct 26, 2021

Conversation

barriebyron
Copy link
Contributor

Description

Instead of asking our contributors to manually assign reviewers when they create a PR, let's use the CODEOWNERS file to automatically do this step. I've added myself as a docs reviewer (happy to help if I can, let's see how this goes)

Tasks

  • [ ]

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@barriebyron barriebyron self-assigned this Oct 22, 2021
@barriebyron barriebyron requested a review from jaybxyz October 22, 2021 13:58
Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barriebyron CODEOWNDERS and CONTRIBUTING.md look good to me. However, this PR has the same commits as #188. Did you start this based off edit-farming-spec branch?

@barriebyron
Copy link
Contributor Author

@barriebyron CODEOWNDERS and CONTRIBUTING.md look good to me. However, this PR has the same commits as #188. Did you start this based off edit-farming-spec branch?

(hanging head in shame) yes I did... bad thing. Okay, I got the unintended changes out of this PR. (whew)
I need to quit working when my eyes and brain are tired. thank you for noticing and understanding that's what I did.

@jaybxyz
Copy link
Contributor

jaybxyz commented Oct 26, 2021

@barriebyron Thanks for resolving the unintended changes. Now this PR has two files changed. It looks like Markdown links checker found 1 dead link in ./docs/Explanation/ADR/README.md. We should resolve this before merging this PR.

@jaybxyz
Copy link
Contributor

jaybxyz commented Oct 26, 2021

I go to the link and the site seems to be live and there seems to be no issue. I assume either Markdown links checker was not properly checking links at the time you pushed your commit or the site was down for a moment when it checked. Let's merge this after a review from @dongsam for this PR. We need to do "Squash and Merge" this since it has lousy commits.

@jaybxyz jaybxyz requested a review from dongsam October 26, 2021 02:26
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, I just force-pushed with resolving codecov fail by branch conflict

@barriebyron barriebyron merged commit 4a8eadd into main Oct 26, 2021
@barriebyron barriebyron deleted the create-codeowners branch October 26, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants