Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add more clear and description comments #158

Merged
merged 7 commits into from
Oct 14, 2021

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Oct 6, 2021

Description

closes: #152

Tasks


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz
Copy link
Contributor Author

jaybxyz commented Oct 13, 2021

Should we R4R @hallazzang ? I'll actually go review the changes and see if there is any typo or places that need more description.

@jaybxyz
Copy link
Contributor Author

jaybxyz commented Oct 13, 2021

The below line is just a minor stuff that I found. We can R4R now and change the minor stuff later when we need.

Should we remove the line?
https://github.com/kogisin/farming/blob/5ffc807b415d623dca28f59bdca9a4cf5bc57a23/x/farming/keeper/reward.go#L421

@hallazzang
Copy link
Contributor

@kogisin Yes we can remove that line and make this PR ready for review.

@jaybxyz jaybxyz marked this pull request as ready for review October 14, 2021 04:42
@jaybxyz jaybxyz requested a review from dongsam October 14, 2021 04:44
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hallazzang hallazzang merged commit f3271cb into tendermint:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add more clear and description comments
3 participants