-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add more clear and description comments #158
docs: add more clear and description comments #158
Conversation
Should we R4R @hallazzang ? I'll actually go review the changes and see if there is any typo or places that need more description. |
The below line is just a minor stuff that I found. We can R4R now and change the minor stuff later when we need. Should we remove the line? |
@kogisin Yes we can remove that line and make this PR ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
closes: #152
Tasks
client
folder to improve comments @kogisinkeeper
folder to improve comments @hallazzangscan through@kogisin (found some comments for TODOs and this is better to be handled with test: Improve public plan proposal simulations #108simulation
folder to improve commentstypes
folder to improve comments @hallazzangBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes