Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add budget module on simapp #118

Merged
merged 32 commits into from
Sep 16, 2021

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Sep 16, 2021

Description

closes: #113


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

jaybxyz and others added 21 commits September 13, 2021 20:55
…96-fix-epoch-params

* commit '600c2cc0597050f283a10a0128d9d56c9f7bb671':
  fix: add exception logic to unpack for unregistered case
  fix: remove deprecated PlansByFarmer index
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #118 (bc6c13b) into master (f03a6b8) will increase coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   69.60%   69.67%   +0.07%     
==========================================
  Files          25       25              
  Lines        2260     2259       -1     
==========================================
+ Hits         1573     1574       +1     
+ Misses        534      533       -1     
+ Partials      153      152       -1     
Impacted Files Coverage Δ
x/farming/module.go 53.12% <0.00%> (-0.73%) ⬇️
x/farming/types/keys.go 71.23% <ø> (ø)
x/farming/types/utils.go 100.00% <ø> (+40.00%) ⬆️
x/farming/keeper/epoch.go 72.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03a6b8...bc6c13b. Read the comment docs.

jaybxyz and others added 8 commits September 16, 2021 19:37
…96-fix-epoch-params

# Conflicts:
#	proto/tendermint/farming/v1beta1/query.proto
#	x/farming/keeper/grpc_query.go
#	x/farming/types/farming.pb.go
#	x/farming/types/query.pb.go
#	x/farming/types/query.pb.gw.go
…96-fix-epoch-params

# Conflicts:
#	proto/tendermint/farming/v1beta1/genesis.proto
#	x/farming/client/cli/query.go
#	x/farming/keeper/epoch_test.go
#	x/farming/keeper/genesis.go
#	x/farming/keeper/keeper_test.go
#	x/farming/types/farming.pb.go
#	x/farming/types/genesis.go
#	x/farming/types/genesis.pb.go
…-on-simapp

# Conflicts:
#	proto/tendermint/farming/v1beta1/genesis.proto
…budget-module-on-simapp

# Conflicts:
#	proto/tendermint/farming/v1beta1/genesis.proto
#	x/farming/types/utils.go
@dongsam dongsam self-assigned this Sep 16, 2021
@dongsam dongsam requested a review from jaybxyz September 16, 2021 14:34
@dongsam dongsam merged commit e64f916 into tendermint:master Sep 16, 2021
jaybxyz added a commit to jaybxyz/farming that referenced this pull request Sep 17, 2021
* master:
  feat: add budget module on simapp (tendermint#118)
  feat: fix epoch params (tendermint#103)
  chore: fix typo
  test: add TestOutstandingRewards
  style: sort imports
  feat: add AdvanceEpoch message and tx cli endpoint
  feat: add cli query commands
  test: write test for Rewards query endpoint
  test: write test for TotalStaking query endpoint
  test: write test for Staking query endpoint
  feat: implement new query endpoints
  docs: update spec document
  fix: include OutstandingRewards in genesis
  fix: fix epoch advancing criteria
  fix: use sdk.DecCoins for rewards
  fix: set total staking on InitGenesis and use helper methods
  feat: add OutstandingRewards
  chore: remove unnecessary validation from InitGenesis
  fix: fix InitGenesis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Budget Module on simapp
2 participants