feat: Implement CLI query endpoints and add AdvanceEpoch msg #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also rename some fields and methods
it's useful to have AdvanceEpoch when testing, but it should be removed for real-world application. so only using special build flags can enable this feature.
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 65.39% 65.50% +0.11%
==========================================
Files 24 24
Lines 2040 2128 +88
==========================================
+ Hits 1334 1394 +60
- Misses 575 597 +22
- Partials 131 137 +6
Continue to review full report at Codecov.
|
16 tasks
dongsam
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
LGTM, thanks for adding the flag for testing
The test task has not been completed yet, but it has become R4R for Demo and #116 first.
If you set the epic issue to closes: in PR, all the tasks of the epic are not finished yet and may be closed. Therefore, could you remove the closes: and create an issue for CLI Tests and replace the Tests checkbox on this PR description?
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds CLI query endpoints and AdvanceEpoch functionality.
Tasks
AdvanceEpochmsg and handlerReferences
See local-testing branch for the detail about
AdvanceEpoch.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Files changedin the Github PR explorerCodecov Reportin the comment section below once CI passes