Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement query endpoints #114

Merged
merged 4 commits into from
Sep 16, 2021

Conversation

hallazzang
Copy link
Contributor

@hallazzang hallazzang commented Sep 15, 2021

Description

closes:

Tasks

  • /stakings/{farmer}
  • /total_stakings/{staking_coin_denom}
  • /rewards/{farmer}
  • Write tests

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@hallazzang hallazzang added the enhancement New feature or request label Sep 15, 2021
@hallazzang hallazzang added this to the Farming F1 MVP milestone Sep 15, 2021
@hallazzang hallazzang self-assigned this Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #114 (736d3e8) into master (600c2cc) will increase coverage by 0.62%.
The diff coverage is 85.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   65.39%   66.01%   +0.62%     
==========================================
  Files          24       24              
  Lines        2040     2107      +67     
==========================================
+ Hits         1334     1391      +57     
- Misses        575      580       +5     
- Partials      131      136       +5     
Impacted Files Coverage Δ
x/farming/types/keys.go 0.00% <0.00%> (ø)
x/farming/keeper/reward.go 87.57% <66.66%> (ø)
x/farming/keeper/grpc_query.go 86.86% <85.50%> (-1.72%) ⬇️
x/farming/keeper/staking.go 90.47% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 600c2cc...736d3e8. Read the comment docs.

@hallazzang hallazzang marked this pull request as ready for review September 16, 2021 04:57
@hallazzang hallazzang requested a review from dongsam September 16, 2021 04:57
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, If you set the epic issue to closes: in PR, all the tasks of the epic are not finished yet and may be closed. Therefore, I just modified the closes:.

@dongsam dongsam merged commit 9d7cd9c into tendermint:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants