fix: panic when unstake due to total stakings is not set

tendermint · Sep 16, 2021 · 33b41ad · 33b41ad
1 parent 3760c11
commit 33b41ad
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/x/farming/client/cli/cli_test.go b/x/farming/client/cli/cli_test.go
@@ -1,3 +1,5 @@
+// +build norace
+
 package cli_test
 
 import (
@@ -20,8 +22,6 @@ import (
 	farmingtypes "github.com/tendermint/farming/x/farming/types"
 )
 
-// // +build norace
-
 type IntegrationTestSuite struct {
 	suite.Suite
 

diff --git a/x/farming/keeper/staking.go b/x/farming/keeper/staking.go
@@ -264,7 +264,9 @@ func (k Keeper) Unstake(ctx sdk.Context, farmerAcc sdk.AccAddress, amount sdk.Co
 			k.DeleteQueuedStaking(ctx, coin.Denom, farmerAcc)
 		}
 
-		k.DecreaseTotalStakings(ctx, coin.Denom, removedFromStaking)
+		if removedFromStaking.IsPositive() {
+			k.DecreaseTotalStakings(ctx, coin.Denom, removedFromStaking)
+		}
 	}
 
 	if err := k.ReleaseStakingCoins(ctx, farmerAcc, amount); err != nil {