Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tidy expected_keeper, module interface #76

Merged

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Oct 27, 2021

Description

  • Limiting BankKeeper and AccountKeeper expected functions to only these used functions
  • Unused args of beginBlocker, and EndBlocker were removed
  • Remove duplicate calls of SetModuleAccount

as suggested from SimplyVC


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dongsam dongsam self-assigned this Oct 27, 2021
@dongsam dongsam added this to the Budget v1.0 milestone Oct 27, 2021
@dongsam dongsam added the enhancement New feature or request label Oct 27, 2021
This was referenced Oct 27, 2021
@dongsam dongsam requested review from jaybxyz and hallazzang October 27, 2021 04:24
@dongsam dongsam merged commit 1368a47 into tendermint:main Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants