Fix AC_AZURE_0185 policy

[maxgio92]

This PR should fix the rego policy for Azure Container Registry which ensure the presence of a Azure Management Lock on that resource (AC_AZURE_0185).

In particular it adds a case that should be also accepted.

This Rego expression is evaluated to true when the azurerm_management_lock resource has the correct scope field value.
In particular this is relevant for the validation of the HCL code.

The scope value can be a Terraform attribute reference expression that references the id attribute of the azurerm_container_registry resource to be locked.

So, for example:

resource "azurerm_container_registry" "foo" {
  name = "foo"
  # ...
}

resource "azurerm_management_lock" "bar" {
  name = "bar"
  scope      = azurerm_container_registry.foo.id
  lock_level = "CanNotDelete"
}

Without this new Rego expression the only accepted HCL code is when the azurerm_managament_lock resource name field is equal to a string composed like this: ""<resource_to_lock_type>.<resource_to_lock_name>". For example:

resource "azurerm_container_registry" "foo" {
  name = "foo"
  # [...]
}

resource "azurerm_management_lock" "bar" {
  name       = "azurerm_container_registry.foo" # Only accepted value
  scope      = azurerm_container_registry.foo.id
  lock_level = "CanNotDelete"
}

This shouldn't add regression as when the scope value has always to match the resource name of the registry from the Rego input.

Furthermore, this is pretty similar to what is declared for Resource Group locking.

What do you think?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov]

Codecov Report

Merging #858 (9725339) into master (617ef74) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #858   +/-   ##
=======================================
  Coverage   78.29%   78.29%           
=======================================
  Files         164      164           
  Lines        4359     4359           
=======================================
  Hits         3413     3413           
  Misses        730      730           
  Partials      216      216           

[harkirat22]

Thanks @maxgio92 for you contribution. These changes LGTM