Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

policy download refactor #618

Merged
merged 1 commit into from
Mar 15, 2021
Merged

policy download refactor #618

merged 1 commit into from
Mar 15, 2021

Conversation

devang-gaur
Copy link
Contributor

fixes #614

@devang-gaur devang-gaur requested a review from jlk March 15, 2021 20:48
@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jlk
jlk approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@jlk jlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Could maybe improve logging in connected()?

pkg/initialize/run.go Show resolved Hide resolved
@devang-gaur devang-gaur merged commit b6732c7 into tenable:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlk jlk jlk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed to initialize terrascan. error : failed to install policies
2 participants
@devang-gaur @jlk