Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cft map for elb and s3 bucket #1434

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

gaurav-gogia
Copy link
Contributor

No description provided.

@gaurav-gogia gaurav-gogia self-assigned this Oct 27, 2022
@gaurav-gogia gaurav-gogia requested a review from a team as a code owner October 27, 2022 13:58
@sonarcloud
Copy link

sonarcloud bot commented Nov 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #1434 (e8c045b) into master (d2f8770) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1434   +/-   ##
=======================================
  Coverage   77.31%   77.32%           
=======================================
  Files         279      279           
  Lines        7878     7881    +3     
=======================================
+ Hits         6091     6094    +3     
  Misses       1427     1427           
  Partials      360      360           
Impacted Files Coverage Δ
...ders/cft/config/elasticloadbalancingv2-listener.go 100.00% <100.00%> (ø)
...apper/iac-providers/cft/config/s3-bucket-policy.go 100.00% <100.00%> (ø)

Copy link
Contributor

@nasir-rabbani nasir-rabbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaurav-gogia gaurav-gogia merged commit 5a49729 into tenable:master Nov 1, 2022
@gaurav-gogia gaurav-gogia deleted the update/cft-map branch November 2, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants