Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention pre-requirements in the README #1375

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Mention pre-requirements in the README #1375

merged 2 commits into from
Sep 1, 2022

Conversation

VeraBE
Copy link
Contributor

@VeraBE VeraBE commented Aug 29, 2022

Closes #1345

@VeraBE VeraBE requested review from a team and bkizer-tenable as code owners August 29, 2022 23:33
gaurav-gogia
gaurav-gogia suggested changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@gaurav-gogia gaurav-gogia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change:
Should be minimum go version 1.17

I can't recall any breaking changes between 1.7 & 1.17 but I feel it'll be safer to use 1.17 since it's the one mentioned in go.mod file

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gaurav-gogia gaurav-gogia merged commit 6da2dca into tenable:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaurav-gogia gaurav-gogia gaurav-gogia approved these changes

@bkizer-tenable bkizer-tenable Awaiting requested review from bkizer-tenable bkizer-tenable is a code owner

Assignees

@VeraBE VeraBE

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs don't mention pre-requirements
2 participants
@VeraBE @gaurav-gogia