Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/endpoint policy download #1200

Merged
merged 25 commits into from
Mar 31, 2022
Merged

Feature/endpoint policy download #1200

merged 25 commits into from
Mar 31, 2022

Conversation

gaurav-gogia
Copy link
Contributor

  • add two new params environment and access_token for the config file
  • download policies from authenticated endpoint
  • convert policies into terrascan accepted format
  • write test case for folder creation, file writing, file conversion conversion

@gaurav-gogia gaurav-gogia added enhancement go Pull requests that update Go code labels Mar 25, 2022
@gaurav-gogia gaurav-gogia self-assigned this Mar 25, 2022
@gaurav-gogia gaurav-gogia requested a review from a team as a code owner March 25, 2022 00:10
patilpankaj212
patilpankaj212 suggested changes Mar 25, 2022
View reviewed changes
pkg/initialize/run.go Outdated Show resolved Hide resolved
pkg/initialize/run.go Outdated Show resolved Hide resolved
pkg/initialize/run.go Outdated Show resolved Hide resolved
pkg/initialize/run.go Outdated Show resolved Hide resolved
pkg/initialize/run.go Outdated Show resolved Hide resolved
pkg/initialize/run_test.go Show resolved Hide resolved
pkg/initialize/types.go Show resolved Hide resolved
pkg/initialize/run.go Outdated Show resolved Hide resolved
pkg/initialize/run.go Outdated Show resolved Hide resolved
pkg/initialize/run.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 28, 2022 •
edited
Loading

Codecov Report

Merging #1200 (6e9850f) into master (830e079) will decrease coverage by 0.47%.
The diff coverage is 49.63%.

❗ Current head 6e9850f differs from pull request most recent head b9fae1f. Consider uploading reports for the commit b9fae1f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1200      +/-   ##
==========================================
- Coverage   78.39%   77.92%   -0.48%     
==========================================
  Files         271      272       +1     
  Lines        7509     7634     +125     
==========================================
+ Hits         5887     5949      +62     
- Misses       1287     1337      +50     
- Partials      335      348      +13
Impacted Files Coverage Δ
pkg/config/global.go 71.08% <10.00%> (-8.37%) ⬇️
pkg/initialize/run.go 47.24% <40.20%> (-17.05%) ⬇️
pkg/initialize/types.go 93.33% <93.33%> (ø)

cesar-rodriguez
cesar-rodriguez reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@cesar-rodriguez cesar-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also update the docs here: https://github.com/accurics/runterrascan.io?

patilpankaj212
patilpankaj212 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@patilpankaj212 patilpankaj212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

Gaurav Gogia and others added 22 commits March 31, 2022 15:35
@gaurav-gogia
phase 1
dc18512
@gaurav-gogia
download commercial poilcies phase 2
7fda948
@gaurav-gogia
phase 3
1b652e6
@gaurav-gogia
unescape characters in json metadata
710b768
@gaurav-gogia
add test data
b209eb4
@gaurav-gogia
add test case for conversion
bef69fb
@gaurav-gogia
fix variable name
6eec9e8
@gaurav-gogia
status code check add
17a8891
@gaurav-gogia
add response status code
8c14122
@gaurav-gogia
add comments for exported functions
e07f14e
@gaurav-gogia
make empty docker folder to satisfy dir structure
0d4006d
@gaurav-gogia
change to use 'environment' keyword
e12b6a3
@gaurav-gogia
env keyword, %w to wrap errors
2270852
@gaurav-gogia
add file hader
3459439
@gaurav-gogia
wrap errors in %w
d923814
@gaurav-gogia
rm tabsapce const
cba2a80
@gaurav-gogia
addressing review comments
c723f40
@gaurav-gogia
use bytes.equal
a6d91ad
@gaurav-gogia
add method for getType, constructor for newPolicy
1a74a0a
@gaurav-gogia
changes:
98d8cd7 
1. save IO operations, avoid overwriting rego code file
2. wrap errors wherever required
@gaurav-gogia
invalid policy test cases
aaead55
@gaurav-gogia
add table error cases structure
ef32768
@gaurav-gogia gaurav-gogia force-pushed the feature/endpoint-policy-download branch from 6e9850f to b9fae1f Compare March 31, 2022 10:05
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gaurav-gogia gaurav-gogia merged commit d818b60 into tenable:master Mar 31, 2022
@gaurav-gogia gaurav-gogia deleted the feature/endpoint-policy-download branch March 31, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesar-rodriguez cesar-rodriguez cesar-rodriguez left review comments

@patilpankaj212 patilpankaj212 patilpankaj212 approved these changes

Assignees

@gaurav-gogia gaurav-gogia

Labels
enhancement go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaurav-gogia @cesar-rodriguez @patilpankaj212