Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub-task's state is to do, but task is done #262

Closed
havengit opened this issue May 22, 2024 · 2 comments
Closed

Sub-task's state is to do, but task is done #262

havengit opened this issue May 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@havengit
Copy link

Sub-task's state is to do, but task is done
SteveMcGrath added a commit that referenced this issue May 22, 2024
@SteveMcGrath
Exception in subtask upsert was hidden by multi-threading #262
b3b3706 
The SubTask upsert method was failing do to the mapping change from 2.0.4, however was masked because this was occuring within a worker thread.  Corrected the issue, Added logic to only use threading when the max_workers is above 1 (for testing), and also added a failsafe to stop execution after processing findings if the number of observed exceptions from the worker jobs is above 0.
SteveMcGrath added a commit that referenced this issue May 22, 2024
@SteveMcGrath
Exception in subtask upsert was hidden by multi-threading #262
900e41c 
The SubTask upsert method was failing do to the mapping change from 2.0.4, however was masked because this was occuring within a worker thread.  Corrected the issue, Added logic to only use threading when the max_workers is above 1 (for testing), and also added a failsafe to stop execution after processing findings if the number of observed exceptions from the worker jobs is above 0.
@SteveMcGrath
Copy link
Collaborator

Can run an automation task to re-open those closed tasks && test with 2.0.5? If you are still seeing issues, I'd like you to set the max_workers to 1 and run again to bypass the thread execution workers.

@SteveMcGrath SteveMcGrath added the bug Something isn't working label May 22, 2024
@havengit
Copy link
Author

yes, set max_workers to 1 and verison 2.0.5, The issue was fix . And the task in "done" state will be reopen to "to do". I think this issue was fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SteveMcGrath @havengit