Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SearchAttributeInput to include type #2439

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

laurakwhit
Copy link
Contributor

Description & motivation 💭

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

When creating or editing a schedule

  • Verify a Bool attribute can be added/edited
  • Verify a Datetime attribute can be added/edited (and is saved in UTC)
  • Verify a Double attribute can be added/edited
  • Verify an Int attribute can be added/edited
  • Verify a Keyword attribute can be added/edited
  • Verify a Text attribute can be added/edited
  • Verify a KeywordList attribute can be added/edited

When editing a search attribute on a schedule

  • Verify changing the attribute clears the value
  • Verify x removes the attribute
  • Verify changing the value is correctly reflected on Save
  • Verify there is an error if Save is attempted and an attribute does not have a value

When starting a workflow

  • Verify search attributes follow same criteria as above ⬆️
  • Verify when starting a workflow with params and there are initial search attributes they show up as expected

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 10:44pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant