Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch namespace_accesses attributes from List to Set type #188

Merged
merged 14 commits into from
Nov 26, 2024
Merged

Switch namespace_accesses attributes from List to Set type #188

merged 14 commits into from
Nov 26, 2024

Conversation

briankassouf
Copy link
Contributor

@briankassouf briankassouf commented Nov 19, 2024 •
edited
Loading

What was changed

Why?

Fixes #176

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@briankassouf briankassouf self-assigned this Nov 21, 2024
@briankassouf briankassouf marked this pull request as ready for review November 22, 2024 19:48
@briankassouf briankassouf requested review from jlacefie and a team as code owners November 22, 2024 19:48
@briankassouf briankassouf merged commit 8860672 into main Nov 26, 2024
5 checks passed
@briankassouf briankassouf deleted the bk/list-to-set-conversion branch November 26, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anekkanti anekkanti anekkanti approved these changes

@jlacefie jlacefie Awaiting requested review from jlacefie jlacefie is a code owner

Assignees

@briankassouf briankassouf

Labels
None yet
Projects
None yet
Milestone
V1.0 | GA - Community Friendly Provider
Development

Successfully merging this pull request may close these issues.

[Bug] Service Account's namespace_accesses attribute is unordered
2 participants
@briankassouf @anekkanti