Support arbitrary history task category in SQL persistence #3489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
commented
Oct 13, 2022
Comment on lines
+288
to
+290
| session_start TIMESTAMP DEFAULT '1970-01-02 00:00:01', | ||
| last_heartbeat TIMESTAMP DEFAULT '1970-01-02 00:00:01', | ||
| record_expiry TIMESTAMP DEFAULT '1970-01-02 00:00:01', |
There was a problem hiding this comment.
yiminc
reviewed
Oct 18, 2022
Comment on lines
+79
to
+80
| `and task_id >= ? ` + | ||
| `and task_id < ?` |
There was a problem hiding this comment.
Yes. This is the correct behavior, all range queries are [inclusive, exclusive).
Didn't discovered this bug before as the code path is never exercised.
Currently we still don't have any queue using this code path (archival queue will be the first one), but at least there're persistence tests ensuring the correct behavior.
yux0
approved these changes
Oct 19, 2022
yycptt
force-pushed
the
sql-arbitrary-task-category
branch
from
3db2a38
to
1c6a997
Compare
norberthu
pushed a commit
that referenced
this pull request
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Is hotfix candidate?