Backoff failed workflow task #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
approved these changes
Feb 25, 2022
This was referenced Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This fixed a regression introduced in 1.15 by PR #2335
Why?
PR #2335 fixed an unnecessary delay after a failed workflow task, but it introduce a serious regression that when workflow task keeps failing, it would fall into a tight loop of retrying.
The fix to the regression is simple, to drop workflow task if it is continuously failing and let it timeout.
How did you test it?
Added integration test to cover invalid command attributes case.
Potential risks
No
Is hotfix candidate?
Yes.