Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ExecutionInfo reference to InternalWorkflowMutation #2530

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Adds ExecutionInfo reference to InternalWorkflowMutation #2530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/persistence/cassandra/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func applyWorkflowMutationBatch(
namespaceID,
workflowID,
runID,
workflowMutation.ExecutionInfo,
workflowMutation.ExecutionInfoBlob,
workflowMutation.ExecutionState,
workflowMutation.ExecutionStateBlob,
workflowMutation.NextEventID,
Expand Down
3 changes: 2 additions & 1 deletion common/persistence/execution_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,7 @@ func (m *executionManagerImpl) SerializeWorkflowMutation(
UpsertRequestCancelInfos: make(map[int64]*commonpb.DataBlob),
UpsertSignalInfos: make(map[int64]*commonpb.DataBlob),

ExecutionInfo: input.ExecutionInfo,
ExecutionState: input.ExecutionState,

DeleteActivityInfos: input.DeleteActivityInfos,
Expand All @@ -500,7 +501,7 @@ func (m *executionManagerImpl) SerializeWorkflowMutation(
NextEventID: input.NextEventID,
}

result.ExecutionInfo, err = m.serializer.WorkflowExecutionInfoToBlob(input.ExecutionInfo, enumspb.ENCODING_TYPE_PROTO3)
result.ExecutionInfoBlob, err = m.serializer.WorkflowExecutionInfoToBlob(input.ExecutionInfo, enumspb.ENCODING_TYPE_PROTO3)
if err != nil {
return nil, err
}
Expand Down
3 changes: 2 additions & 1 deletion common/persistence/persistenceInterface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,8 @@ type (
WorkflowID string
RunID string

ExecutionInfo *commonpb.DataBlob
ExecutionInfo *persistencespb.WorkflowExecutionInfo
ExecutionInfoBlob *commonpb.DataBlob
ExecutionState *persistencespb.WorkflowExecutionState
ExecutionStateBlob *commonpb.DataBlob
NextEventID int64
Expand Down
2 changes: 1 addition & 1 deletion common/persistence/size.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func statusOfInternalWorkflowMutation(
return nil
}

executionInfoSize := sizeOfBlob(mutation.ExecutionInfo)
executionInfoSize := sizeOfBlob(mutation.ExecutionInfoBlob)
executionStateSize := sizeOfBlob(mutation.ExecutionStateBlob)

activityInfoCount := len(mutation.UpsertActivityInfos)
Expand Down
2 changes: 1 addition & 1 deletion common/persistence/sql/execution_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func applyWorkflowMutationTx(
tx,
namespaceID,
workflowID,
workflowMutation.ExecutionInfo,
workflowMutation.ExecutionInfoBlob,
workflowMutation.ExecutionState,
workflowMutation.NextEventID,
lastWriteVersion,
Expand Down