Allow customizing retry behavior for timeout failure #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
changed the title
yiminc
approved these changes
Feb 19, 2022
service/history/workflow/retry.go
Outdated
Comment on lines
168
to
170
| if strings.HasPrefix(nrt, common.TimeoutFailureTypePrefix) { | ||
| continue | ||
| } |
common/constants.go
Outdated
| // used in retry policy | ||
| // the actual failure type will be prefix + enums.TimeoutType.String() | ||
| // e.g. "Temporal Timeout: StartToClose" or "Temporal Timeout: Heartbeat" | ||
| TimeoutFailureTypePrefix = "Temporal Timeout: " |
There was a problem hiding this comment.
Maybe we should avoid space in the prefix?
There was a problem hiding this comment.
👍 Yup, this is a programmatic name not a sentence.
There was a problem hiding this comment.
Sure. Removed both spaces, and now it becomes TemporalTimeout:
cretz
approved these changes
Feb 22, 2022
common/constants.go
Outdated
| // used in retry policy | ||
| // the actual failure type will be prefix + enums.TimeoutType.String() | ||
| // e.g. "Temporal Timeout: StartToClose" or "Temporal Timeout: Heartbeat" | ||
| TimeoutFailureTypePrefix = "Temporal Timeout: " |
There was a problem hiding this comment.
👍 Yup, this is a programmatic name not a sentence.
yux0
pushed a commit
that referenced
this pull request
Feb 25, 2022
This was referenced Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Allow customizing retry behavior for timeout errors
Why?
#2496
How did you test it?
Added unit test
Potential risks
This change is technically breaking as the new format defined for timeout failure may matching user defined application error types. But the chance this will happen is very very low.
Is hotfix candidate?
no