Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TaskQueue inheritance when workflow is continued as new #471

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented Jul 2, 2024

What was changed

Add inheritance of TaskQueue from the parent when ContinueAsNew options DTO is created

Why?

It's expected behavior

Checklist

  1. Closes ContinueAsNew options dto doesn't inherit Workflow's Task Queue #453
  2. How was this tested: added autotest

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 7:17pm

@roxblnfk roxblnfk requested a review from wolfy-j July 2, 2024 19:16
@roxblnfk roxblnfk changed the title Fix/continue as new task queue Fix TaskQueue inheritance when workflow is continued as new Jul 2, 2024
@roxblnfk roxblnfk merged commit adcfc27 into master Jul 2, 2024
92 checks passed
@roxblnfk roxblnfk deleted the fix/continue-as-new-task-queue branch July 2, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContinueAsNew options dto doesn't inherit Workflow's Task Queue
2 participants