Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WorkflowClient] fixed return template method newRunningWorkflowStub #363

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

root-aza
Copy link
Contributor

What was changed

Arg $class at the method newRunningWorkflowStub, Contract WorkflowClientInterface

Why?

corrects the return type of the newRunningWorkflowStub method

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2023

CLA assistant check
All committers have signed the CLA.

@root-aza
Copy link
Contributor Author

@roxblnfk cc

@roxblnfk roxblnfk modified the milestones: 2.6.0, 2.6.1 Oct 11, 2023
@roxblnfk
Copy link
Collaborator

Hi @root-aza. Thanks for the PR. Need to sign it.

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@root-aza
Copy link
Contributor Author

Hi @root-aza. Thanks for the PR. Need to sign it.

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

ready ✅

@roxblnfk roxblnfk merged commit 67ccb2a into temporalio:master Oct 11, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants