Improve Update Workflow testing UX #1721
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion for ergonomics
|
@Quinn-With-Two-Ns lmk if there's other improvements you were thinking about when you filed the issue that I didn't cover |
| // TestUpdateCallback is a basic implementation of the UpdateCallbacks interface for testing purposes. | ||
| // Tests are welcome to implement their own version of this interface if they need to test more complex | ||
| // update logic. This is a simple implementation to make testing basic Workflow Updates easier. | ||
| TestUpdateCallback struct { |
There was a problem hiding this comment.
The issue was intended to improve the UX for users so we would need to expose this https://github.com/temporalio/sdk-go/blob/master/testsuite/testsuite.go#L35
There was a problem hiding this comment.
oops! didn't realize this was needed. Thanks for pointing it out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added default implementation
TestUpdateCallbacksfor basic test scenariosWhy?
so tests don't need to implement
UpdateCallbacksthemselves. To make testing a little easierChecklist
Closes Improve UX for testing Workflow Update with the Workflow Test Environment #1639
How was this tested:
existing unit tests that were effected still pass