Fix failure_reason label for nexus_task_execution_failed metric on task timeout #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| require.Equal(t, nexus.StatusDownstreamTimeout, unexpectedResponseErr.Response.StatusCode) | ||
|
|
||
| require.EventuallyWithT(t, func(t *assert.CollectT) { | ||
| tc.requireFailureCounter(t, service.Name, syncOp.Name(), "timeout") |
There was a problem hiding this comment.
Why only assert the failure counter? shouldn't NexusTaskScheduleToStartLatency be published?
There was a problem hiding this comment.
I figured it's covered in the other tests.
There was a problem hiding this comment.
hm I think this case is different because we don't report E2E latency on timeout
There was a problem hiding this comment.
I know, I meant the other two metrics. In any case, I've added the tests.
Quinn-With-Two-Ns
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mistakenly reported timeouts as
internal_sdk_error. I'll update the docs site as well.