Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more marshaler options for ProtoJson converter #1286

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

vbmithr
Copy link
Contributor

@vbmithr vbmithr commented Oct 30, 2023

What was changed

I added options to be passed to marshaler code for Proto/JSON.

Why?

Automatic OCaml deserialization of JSON-encoded Protobuf does not work if empty (nil) fields are not present.

Checklist

  1. Closes

  2. How was this tested:

I observed in my own code the expected result, i.e. JSON-encoded Protobuf now contains nil fields.

  1. Any docs updates needed?

@vbmithr vbmithr requested a review from a team as a code owner October 30, 2023 23:08
@CLAassistant
Copy link

CLAassistant commented Oct 30, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will let @Quinn-With-Two-Ns look

@cretz cretz merged commit 0352634 into temporalio:master Oct 31, 2023
8 checks passed
@cretz
Copy link
Member

cretz commented Oct 31, 2023

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants