Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix some errors with rule identifiers #1281

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Oct 26, 2023

What was changed

Add a couple of https://github.com/temporalio/rules references as error prefixes

@Quinn-With-Two-Ns
Copy link
Contributor

Just an FYI your missing a few panics for rule TMPRL1100, for example:

func (up *updateProtocol) requireState(action string, valid ...updateState) {
	for _, validState := range valid {
		if up.state == validState {
			return
		}
	}
	panicIllegalState(fmt.Sprintf("invalid action %q in update protocol %v", action, up))
}

should be tagged. Any panicIllegalState should be tagged with TMPRL1100

@cretz cretz marked this pull request as ready for review February 1, 2024 15:49
@cretz cretz requested a review from a team as a code owner February 1, 2024 15:49
@cretz
Copy link
Member Author

cretz commented Feb 1, 2024

@Quinn-With-Two-Ns et al - This is now ready for review

@cretz cretz merged commit a7c9528 into temporalio:master Feb 1, 2024
12 checks passed
@cretz cretz deleted the temporal-rules branch February 1, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants