La metrics #815
Merged
La metrics #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Probably need another issue somewhere to update https://docs.temporal.io/references/sdk-metrics to include Core on these now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added local activity metrics to core. No flag needed as these were not being recorded under existing activity metrics anyway.
Why?
Parity with other SDKs
Checklist
Closes Support local_activity_X based metrics in Core-based SDKs features#522
How was this tested:
Added integ test against Prometheus metrics
Any docs updates needed?
Yes, docs site needs tables etc on metrics page updated