-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add example using Sentry V2 SDK #140
Open
gregbrowndev
wants to merge
9
commits into
temporalio:main
Choose a base branch
from
gregbrowndev:feat/sentry-v2-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+76
−42
Commits on Sep 7, 2024
-
feat: add example using Sentry V2 SDK
Notes: The V1 example doesn't seem to work for me after recently trying to set up Sentry. The issue seems to be related to the `warnings` and `threading` modules that Sentry uses not being included properly into the Temporal Workflow's sandbox. This results in the Workflow execution failing to start in the worker that handles the Workflow. I don't see any issues with the Sentry interceptor on other workers that only handle activities, so it is definitely related to the Workflow sandbox. Note: I also tried disabling the worker's sandbox and this seemed to work, even though you get a sporadic error in the Temporal UI. The solution seems to be to migrate the interceptor to use V2 of Sentry's SDK, where the Hub object is now deprecated in favour of using scopes. It seems that using the scope context manager doesn't have the same issues with the warnings and threading libs (which it does still use). I've created a new example to keep the V1 example in place, since V2 only works with Python 3.6 or above.
Configuration menu - View commit details
-
Copy full SHA for fe65b3c - Browse repository at this point
Copy the full SHA fe65b3cView commit details
Commits on Nov 14, 2024
-
- Renamed sentry sample to sentry_v1 until it reaches EOL - Clarified readme for both samples
Configuration menu - View commit details
-
Copy full SHA for d69c035 - Browse repository at this point
Copy the full SHA d69c035View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ed6b30 - Browse repository at this point
Copy the full SHA 1ed6b30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cd79d6 - Browse repository at this point
Copy the full SHA 5cd79d6View commit details
Commits on Nov 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c88a03e - Browse repository at this point
Copy the full SHA c88a03eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6381dd9 - Browse repository at this point
Copy the full SHA 6381dd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19c9359 - Browse repository at this point
Copy the full SHA 19c9359View commit details
Commits on Nov 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 46cd182 - Browse repository at this point
Copy the full SHA 46cd182View commit details
Commits on Dec 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d793b15 - Browse repository at this point
Copy the full SHA d793b15View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.