Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example using Sentry V2 SDK #140

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Commits on Sep 7, 2024

  1. feat: add example using Sentry V2 SDK

    Notes: The V1 example doesn't seem to work for me after recently trying
    to set up Sentry. The issue seems to be related to the `warnings` and
    `threading` modules that Sentry uses not being included properly into
    the Temporal Workflow's sandbox. This results in the Workflow execution
    failing to start in the worker that handles the Workflow. I don't see any
    issues with the Sentry interceptor on other workers that only handle
    activities, so it is definitely related to the Workflow sandbox.
    
    Note: I also tried disabling the worker's sandbox and this seemed to work,
    even though you get a sporadic error in the Temporal UI.
    
    The solution seems to be to migrate the interceptor to use V2 of Sentry's
    SDK, where the Hub object is now deprecated in favour of using scopes.
    
    It seems that using the scope context manager doesn't have the same issues
    with the warnings and threading libs (which it does still use).
    
    I've created a new example to keep the V1 example in place, since V2 only
    works with Python 3.6 or above.
    gregbrowndev committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    fe65b3c View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. wip: code review

    - Renamed sentry sample to sentry_v1 until it reaches EOL
    - Clarified readme for both samples
    gregbrowndev committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d69c035 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ed6b30 View commit details
    Browse the repository at this point in the history
  3. wip: improve readmes

    gregbrowndev committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5cd79d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Configuration menu
    Copy the full SHA
    c88a03e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6381dd9 View commit details
    Browse the repository at this point in the history
  3. wip: clean up

    gregbrowndev committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    19c9359 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Configuration menu
    Copy the full SHA
    46cd182 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Configuration menu
    Copy the full SHA
    d793b15 View commit details
    Browse the repository at this point in the history