EDU-8: Update source code for "Run your first app in Java" and port to Maven #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Source code updated * Ported to Maven * Transaction details are now a single type * Jackson Deserialization is now supported for the custom type * Test run and pass * Worker runs correctly * Caller app runs correctly JIRA: https://temporalio.atlassian.net/browse/EDU-2293
* Change amount from double to int
* Added toggles to control the success of the deposit and refund
* Add compensation mechanism to refund failed deposit
JIRA: https://temporalio.atlassian.net/browse/EDU-2293
fairlydurable
changed the title
fairlydurable
added a commit
that referenced
this pull request
Jun 24, 2024
…o Maven (#29) * EDU-2293: Update source code for "Run your first app in Java" and port to Maven JIRA: https://temporalio.atlassian.net/browse/EDU-2293 * EDU-2293: Update source code for "Run your first app in Java" * Source code updated * Ported to Maven * Transaction details are now a single type * Jackson Deserialization is now supported for the custom type * Test run and pass * Worker runs correctly * Caller app runs correctly JIRA: https://temporalio.atlassian.net/browse/EDU-2293 * EDU-2293: Update source code for "Run your first app in Java" * Change amount from double to int * Added toggles to control the success of the deposit and refund * Add compensation mechanism to refund failed deposit JIRA: https://temporalio.atlassian.net/browse/EDU-2293 * EDU-2293: updated to rethrow exception in Workflow fail case JIRA: https://temporalio.atlassian.net/browse/EDU-2293 Updates project to use `refund` as separate method converts transactionDetails from camel to kebab 5000 retries Clean up Makefile Makefile 5000 retries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes in explanations.
I did not simplify anything, although parts might be unnecessarily complicated to new adopters. This issue definitely worth discussing and I will re-evaluate after updating and snipsyncing the tutorial portion of the work.
UPDATE: added a single transaction type to bring the sample in-line with the other SDKS.
UPDATE: Jackson serialization is now supported by the custom type.
JIRA: https://temporalio.atlassian.net/browse/EDU-2293