-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync to latest API Cloud to include Export #190
Conversation
2753319
to
c47afb0
Compare
c47afb0
to
a4cd3c7
Compare
Looks like a lot of unrelated files were changed in this PR. I would guess due to using a different version of the protoc plugin. Can you confirm that this is intentional? |
And can you confirm this is a result of running |
I only added the cloud related files. It has a lot of files as we haven't synced changes in this repo for a while. But if I'm running Do we want to do that as well? Is it from previous pr? |
Looking at the diff on those, it looks like the copyright headers are removed and your version of protoc may be different than what was here before. I'd have to set aside time to investigate, but in theory if your running of the |
9c23bba
to
8d254f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Will you also be doing this for the cloud git submodule inside https://github.com/temporalio/sdk-java/tree/master/temporal-serviceclient/src/main and the cloud git subtree inside https://github.com/temporalio/sdk-core/tree/master/sdk-core-protos/protos (see https://github.com/temporalio/sdk-core?tab=readme-ov-file#proto-files)?
We definitely don't want to favor Go as if it is more important than other languages.
What changed?
Why?
How did you test it?
Potential risks