Generate OpenAPI v2 and v3 specs #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be in the next server RC? |
tdeebswihart
force-pushed
the
tds/openapi-spec-generation
branch
from
56ab32d to
711793f
Compare
No. We plan to release this in a point release |
cretz
reviewed
Feb 9, 2024
cretz
reviewed
Feb 12, 2024
cretz
reviewed
Feb 12, 2024
cretz
approved these changes
Feb 12, 2024
This requires a tiny bit of post-processing to support our shorthand payload types
tdeebswihart
force-pushed
the
tds/openapi-spec-generation
branch
from
88d0674 to
56ec19b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We now generate openapi v2 (swagger) and v3 specs as a part of proto compilation.
Why?
So that we can serve these on our HTTP API
How did you test it?
Build and run temporalio/temporal#5393 (make start-dependencies + make start)
Potential risks