Skip to content

Commit

Permalink
Update go.sum before building proxygen (#106)
Browse files Browse the repository at this point in the history
* Update go.sum before building proxygen

The unpinned versions (e.g. we depend on the latest version of
google.golang.org/genproto) change frequently and if the go.sum isn't
updated, builds will fail.

* Bump the go version used by ci workflow

Proxy codegen needs 1.18 or higher.
  • Loading branch information
Matt McShane authored Feb 2, 2023
1 parent 35f91d4 commit 445e99d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2
with:
go-version: "1.17"
go-version: "1.18"
- name: Check
run: make check test
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ grpc-mock:
.PHONY: proxy
proxy:
printf $(COLOR) "Generate proxy code..."
(cd ./cmd/proxygenerator && go run ./)
(cd ./cmd/proxygenerator && go mod tidy && go run ./)

goimports:
printf $(COLOR) "Run goimports..."
Expand Down Expand Up @@ -112,7 +112,7 @@ test:

generatorcheck:
printf $(COLOR) "Check generated code is not stale..."
(cd ./cmd/proxygenerator && go run ./ -verifyOnly)
(cd ./cmd/proxygenerator && go mod tidy && go run ./ -verifyOnly)

check: generatorcheck

Expand Down

0 comments on commit 445e99d

Please sign in to comment.