Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade arxiv dependency to 1.4.1 #18

Merged
merged 5 commits into from
Apr 8, 2022
Merged

Conversation

lukasschwab
Copy link
Contributor

@lukasschwab lukasschwab commented Aug 16, 2021

Changes

Testing

Most of the unit tests fail in my local environment, but this seems to be a matter of missing required LaTeX packages: the pdflatex builds fail. You may have better luck in your testing environment!

Some of the tests do pass and generate the expected PDFs, which makes me confident in my use of the upgraded arxiv package. The comparxiv outputs for those failures include the expected authors and titles:

                                    __  ___
  ___ ___  _ __ ___  _ __   __ _ _ _\ \/ (_)_   __
 / __/ _ \| '_ ` _ \| '_ \ / _` | '__\  /| \ \ / /
| (_| (_) | | | | | | |_) | (_| | |  /  \| |\ V /
 \___\___/|_| |_| |_| .__/ \__,_|_| /_/\_\_| \_/
                    |_|

Version 0.1.7, developed by Timon Emken (2020)

Compare [1907.06674]: v2 vs v3

Title:		Death by Dark Matter
Authors:	 Jagjit Singh Sidhu, Robert J Scherrer, Glenn Starkman

1.) Download and unpack source files:

2.1) Identify master tex files:
	1907.06674v2:	main_bob_gds.tex
	1907.06674v3:	main_resubmit.tex

2.2) Identify bbl files:
	1907.06674v2:	main_bob_gds.bbl
	1907.06674v3:	main_resubmit.bbl

3.1) Run latexdiff on the tex files.

3.2) Run latexdiff on the bbl files.

4.) Generate a pdf with pdflatex.
	Warning: No pdf could be generated. Copy the .bbl file of version b and try again.

Failure! No pdf file could be generated.
Troubleshooting:
	1.) To see more terminal output run:
		'comparxiv --show_latex_output 1907.06674 2 3'
	2.) In some cases latex math environments cause problems with latexdiff. Try running:
		'comparxiv --dont_compare_equations 1907.06674 2 3'

Notes

The AttributeError handling corresponds to a known bug: lukasschwab/arxiv.py#80

When that bug is closed, the exception-handling here can be tightened or the list_papers helper can be removed altogether.

Feel free to treat this as really low-priority. The existing usage of the v0 client isn't broken, but v1 is simpler, better-typed, and easier to extend.

@lukasschwab
Copy link
Contributor Author

@temken do you think this merits review?

If yes, I can update the dependency to 1.4.2.

@temken
Copy link
Owner

temken commented Sep 8, 2021

Hi @lukasschwab, This looks great. Apologies for the late reply. I will check the details soon.

@lukasschwab
Copy link
Contributor Author

@temken I'm going to close this so I have fewer open PRs; feel free to reopen it and tag me if you see fit.

Cheers

@temken
Copy link
Owner

temken commented Feb 16, 2022

Thanks @lukasschwab, I will re-open this once I find the time. Apologies for the delay.

@temken temken reopened this Apr 8, 2022
@temken
Copy link
Owner

temken commented Apr 8, 2022

Apologies again for the delay. I appreciate your contribution, the code looks good. I will also update the dependency to 1.4.2.

@temken temken merged commit 5fa5ebc into temken:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants