Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
arxiv==1.4.1
.list_papers
helper to centralize exception-handling for nonexistent IDs.get_short_id
incorrect for pre-March 2007 arXiv identifiers: missing archive lukasschwab/arxiv.py#74.Testing
Most of the unit tests fail in my local environment, but this seems to be a matter of missing required LaTeX packages: the
pdflatex
builds fail. You may have better luck in your testing environment!Some of the tests do pass and generate the expected PDFs, which makes me confident in my use of the upgraded
arxiv
package. Thecomparxiv
outputs for those failures include the expected authors and titles:Notes
The
AttributeError
handling corresponds to a known bug: lukasschwab/arxiv.py#80When that bug is closed, the exception-handling here can be tightened or the
list_papers
helper can be removed altogether.Feel free to treat this as really low-priority. The existing usage of the v0 client isn't broken, but v1 is simpler, better-typed, and easier to extend.