Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Bugfix 9019 threading error #594

Open
wants to merge 2 commits into
base: 2.1.x
Choose a base branch
from
Open

Conversation

Alfro
Copy link
Contributor

@Alfro Alfro commented Sep 7, 2018

No description provided.

Issue is. When drawing_areas is executed that way sometimes after stopping the preview is black
This seems to fix the previous black effect when drawing areas
@Alfro Alfro requested a review from dpeite September 7, 2018 14:15
@andiempettJISC
Copy link
Collaborator

@Alfro if possible could you please write a short explanation of the issue this PR addresses please.
I have seen threading issues around the recorder stopping (galicaster will crash in some weird circumstances).

I see you've made some changes to the recorder here, just wondering about the bug and how you've addressed it

thanks

@Alfro Alfro changed the title Bugfix 9019 threading error WIP: Bugfix 9019 threading error Nov 16, 2018
@Alfro
Copy link
Contributor Author

Alfro commented Nov 16, 2018

Hi @androidwiltron
This is still a work in progress. There is an issue on the current code when calling "record()" twice in a row. I was trying to address it in this PR, but it causes other issues. I should either close it or mark it as WIP for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants