Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #26: Return all open PRs instead of filtering by date #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Feb 9, 2021

  1. Close #26: Return all open PRs instead of filtering by date

    This resource can inadvertently miss Pull Requests due to out-of-order
    commits across PRs.  If PR#2 is opened after PR#1, but the head commit
    of PR#2 is older than the head commit of PR#1, the resource will not
    include PR#2 in the list of new versions provided to Concourse.
    
    Rather than attempt to find a different way of tracking which PRs are
    "new" given an input version, we can remove the date-based filtering
    and return all open PRs.  Concourse can deduplicate versions based on
    metadata, which means that we will only trigger new jobs for versions
    that Concourse hasn't seen before.
    
    This makes it easier for teams to use this resource to track PRs in
    Concourse, since they no longer have to ensure that a PR has a later
    head commit than all currently-opened PRs in order to notify Concourse
    that their PR exists.
    ctreatma committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    b2493fb View commit details
    Browse the repository at this point in the history