Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate dsl pkg #178

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

dwisiswant0
Copy link
Collaborator

IMPORTANT: Please do not create a PR without creating an issue first!

(Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request).

Summary

fb291ac refactor(teler): use external dsl pkg
3323207 refactor(dsl): remove dsl pkg

Proposed of changes

This PR fixes/implements the following bugs/features:

How has this been tested?

Proof:

Closing issues

Fixes #177

Checklist:

  • My code follows the code style of this project.
  • My changes successfully ran and pass linters locally (run make lint).
  • I have written new tests for my changes.
    • My changes successfully ran and pass tests locally.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

@dwisiswant0 dwisiswant0 self-assigned this Mar 27, 2024
@dwisiswant0 dwisiswant0 force-pushed the dwisiswant0/refactor/migrate-dsl-pkg branch from fb291ac to 96e0331 Compare March 27, 2024 07:29
Signed-off-by: Dwi Siswanto <[email protected]>
and update mod for `expr` pkg

Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0 dwisiswant0 force-pushed the dwisiswant0/refactor/migrate-dsl-pkg branch from 96e0331 to 2a9723d Compare March 27, 2024 07:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.36%. Comparing base (2ce165c) to head (2a9723d).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   79.58%   78.36%   -1.23%     
==========================================
  Files          16       12       -4     
  Lines         975      915      -60     
==========================================
- Hits          776      717      -59     
+ Misses        132      131       -1     
  Partials       67       67              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwisiswant0 dwisiswant0 merged commit 39853f2 into master Mar 27, 2024
10 checks passed
@dwisiswant0 dwisiswant0 deleted the dwisiswant0/refactor/migrate-dsl-pkg branch March 27, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] Remove dsl package
2 participants