Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(writer): disable ts key in writer #51

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

dwisiswant0
Copy link
Collaborator

IMPORTANT: Please do not create a PR without creating an issue first!

(Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request).

Summary

Explains the information and/or motivation for making this changes...

Proposed of changes

This PR fixes/implements the following bugs/features:

  • Bug 1
  • Bug 2
  • Feature 1
  • Feature 2
  • Breaking changes

How has this been tested?

Proof:

Closing issues

Fixes #

Checklist:

  • My code follows the code style of this project.
  • My changes successfully ran and pass linters locally (run make lint).
  • I have written new tests for my changes.
    • My changes successfully ran and pass tests locally.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

to prevent multiple key being printed in same logline

Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0 dwisiswant0 added the enhancement New feature or request label Jan 20, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8265b1) 100.00% compared to head (2a7e9da) 100.00%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #51   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           36        36           
=========================================
  Hits            36        36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwisiswant0 dwisiswant0 merged commit 8d6397e into master Jan 20, 2024
6 checks passed
@dwisiswant0 dwisiswant0 deleted the dwisiswant0/fix/disable-ts-key-in-writer branch January 20, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants