-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Azure authentication using Azure AD Tokens #165
Conversation
@alaeddine-13 many thanks for thos PR. Like this:
|
@alaeddine-13 please use the formatter. can do that with A very detailed guide is here: https://github.com/telekom/mltb2/blob/main/CONTRIBUTING.md#testing-linting-and-formatting |
@alaeddine-13 please also add your copyright to the README.md and the LICENSE file. |
Please increase the rc number in |
Hi @alaeddine-13 ! To fix the CI issue with ruff: please do a rebase upstream/main. I fixed the issue there. |
done |
We have this remaining mypy issue:
Should we change back to " |
@alaeddine-13 mypy now fails with:
The What is the reason to make azure_endpoint optional? Can that be changed back? |
@PhilipMay can you run again the CI ? I implemented this workaround here in order to make azure_endpoint a positional argument |
Description
Adds support for Azure authentication using Azure AD Tokens
Pull request checklist
docs/source/api-reference
make sphinx && make open-sphinx
make check
make format
-> None