Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option for OpenAI special token removal. #164

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Option for OpenAI special token removal. #164

merged 2 commits into from
Jun 14, 2024

Conversation

PhilipMay
Copy link
Member

@PhilipMay PhilipMay commented Jun 14, 2024 •
edited
Loading

Description

Pull request checklist

  • tests
    • Do we have tests? Should we add more?
    • Should we parametrize tests?
    • Should we add hypothesis tests?
  • documentation
    • add docstrings
    • if a module is new: add API reference file for Sphinx in docs/source/api-reference
    • check API doc of Sphinx - build and show with make sphinx && make open-sphinx
  • fix checks
    • start locale checks with make check
    • fix formatting with make format
  • Python type info
    • check and improve Python type info
    • double check if return types are specified - including -> None
  • check TODO comments in code
  • check FIXME comments in code
  • check if we want to increase the version or rc number
  • check if the copyright needs an update
    • file header
    • README.md
    • LICENSE file

@PhilipMay PhilipMay merged commit 268dfa0 into main Jun 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PhilipMay