Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fake change #129

Closed
wants to merge 3 commits into from
Closed

fake change #129

wants to merge 3 commits into from

Conversation

PhilipMay
Copy link
Member

@PhilipMay PhilipMay commented Jan 1, 2024 •
edited
Loading

Description

Pull request checklist

  • add tests
  • documentation
    • add docstrings
    • if a module is new: add API reference file for Sphinx in docs/source/api-reference
    • check API doc of Sphinx - build and show with make sphinx && make open-sphinx
  • fix checks
    • start locale checks with make check
    • fix formatting with make format
  • Python type info
    • check and improve Python type info
    • double check if return types are specified - inclusing -> None
  • check TODO comments in code
  • check if the copyright header needs an update
  • check FIXME comments in code

@PhilipMay PhilipMay force-pushed the main branch 2 times, most recently from 8490e60 to 2fe8116 Compare January 1, 2024 19:58
@PhilipMay PhilipMay closed this Jan 1, 2024
@PhilipMay PhilipMay deleted the fake-pr-2 branch January 1, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PhilipMay