Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add postgresql to database module #10

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

hektor1966
Copy link
Contributor

No description provided.

@hektor1966 hektor1966 requested a review from a team as a code owner January 22, 2024 15:14
variables.tf Outdated
/**
compare and merge custom and default values
*/
postgresql_flexible_server_values = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't duplicate the compare block again so please move this to line 147.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, done

/**
deep merge of all custom and default values
*/
postgresql_flexible_server = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't duplicate the compare block again so please move this to line 180

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, is obsolete

@michaelamattes
Copy link
Contributor

@hektor1966 Please change the MR topic and remove your internal ticket ID as this is only your internal tracking and not a ticket accessible from anywhere in Github

@hektor1966 hektor1966 changed the title FGA 1961 add postgresql to database module add postgresql to database module May 21, 2024
@michaelamattes michaelamattes merged commit af375c9 into main Jul 29, 2024
5 checks passed
@michaelamattes michaelamattes deleted the FGA-1961-add_postgresql_to_database_module branch July 29, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants