Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(binaries): Correct set IFS for multiple binaries #87

Closed

Conversation

habr-mms
Copy link

With correctly set IFS in the build step for binaries, more than one binary from Github, Google, etc. can now be loaded into the DMC again.

@michaelamattes
Copy link
Collaborator

Please tell more about failure response from actuell release branch. Furtermore add a second expample in the full_build.yaml so that the Actions can prove the changes.

@habr-mms habr-mms changed the title fix(binaries): Correct set IFS for multiple binariesd fix(binaries): Correct set IFS for multiple binaries Mar 27, 2023
@habr-mms
Copy link
Author

Due to the incorrect IFS definition in the step to download the binaries from Github and Google, only one binary could be loaded successfully at a time. The download failed with more than one binary. With the correct IFS definition, multiple binaries can be loaded again.
I included k9s as the second binary from GitHub in full_build.yaml to test the successful loading of multiple binaries from one source.

@michaelamattes
Copy link
Collaborator

k9s ist included in wakemeops, could we find a better example ?

@michaelamattes
Copy link
Collaborator

solved over #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants