Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for scalar compression issue #140 (obsoleted by #138) #141

Closed
wants to merge 1 commit into from

Conversation

hernot
Copy link
Contributor

@hernot hernot commented Sep 1, 2020

Quick fixes #140 by filtering any hdf5 kwarg related to
compression. A warning is issued that currently compression is not
supported.

Implemented along suggestion proposed in issue #140.

Obsoleted by #138

Quick fixes issue telegraphic#140 by filtering any hdf5 kwarg related to
compression. A warning is issued that currently compression is not
supported.
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #141 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #141   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          576       580    +4     
=========================================
+ Hits           576       580    +4     
Impacted Files Coverage Δ
hickle/hickle.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 861e4ae...c4717a6. Read the comment docs.

@hernot
Copy link
Contributor Author

hernot commented Oct 1, 2020

Hi I just wanted to send a ping from my side. On this suggestion for quickfixing compression bug.

@1313e
Copy link
Collaborator

1313e commented Oct 2, 2020

This one will have to wait until #138 has been dealt with.

@hernot
Copy link
Contributor Author

hernot commented Oct 2, 2020

I would have decided otherwise, as this pr is a suggestion how to quick fix #140 for current production 4.0.0 release. Which i would consider more important than the next step towards unleashing the true powers of hickle proposed in #138. And #138 renders this pr anyway obsolete as it allows to handle, and does so, compression issue #140 on a lot more fine grained and granular level than would be consistently be feasible in 4.0.0 release. Reviewing and if positive merging this first would provide imho a lot more time for thoroughly discussing and reviewing #138 which is admittedly a big step.

@hernot hernot changed the title Quick fix for scalar compression issue #140 Quick fix for scalar compression issue #140 (obsolete after merge of #138) Dec 22, 2020
@hernot hernot changed the title Quick fix for scalar compression issue #140 (obsolete after merge of #138) Quick fix for scalar compression issue #140 (obsolete when #138 merged first) Dec 22, 2020
@hernot hernot changed the title Quick fix for scalar compression issue #140 (obsolete when #138 merged first) Quick fix for scalar compression issue #140 (obsoleted by #138) Dec 22, 2020
@1313e
Copy link
Collaborator

1313e commented Jan 16, 2021

This one is obsolete, as this fix is already implemented in 4.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants