added replace_id attrib to sqlFileStore #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalan
reviewed
Mar 21, 2023
python-lib/tc_etl_lib/README.md
Outdated
Comment on lines
344
to
346
| - :param `replace_id` opcional: diccionario `tipo de entidad` => `lista de atributos replace_id`. | ||
| Reemplaza el ID de las entidades del tipo o tipos especificados, por un valor construido a partir de la lista de atributos indicados en este parámetro, separados por `_`. | ||
| Imita el comportamiento del atributo `replaceId` de los flujos históricos de URBO-DEPLOYER, para poder usar este *store* en ETLs que alimenten *singletons*. |
There was a problem hiding this comment.
Incluir entrada en el changelog (de tipo "Add") por encima de la marca de 0.7.0 (December 233rd, 2022) (de paso, corregir el typo en ese 233 ;)
¿Cómo de urgente/necesario es? ¿Cerramos versión 0.8.0 tras mezclar este fix?
There was a problem hiding this comment.
fix en c8a6a95.
En las ETLs de accommodation-vertical necesitábamos esta funcionalidad. Si se cierra versión lo usamos ya, si no mantenemos el workaround que tenemos en esas ETLs.
fgalan
reviewed
Mar 21, 2023
Co-authored-by: Fermín Galán Márquez <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actualmente el store
sqlFileStoreno puede usarse para generar un fichero SQL de carga de entidades singleton (tal como las define URBO-DEPLOYER, conreplaceId), porque esas entidades necesitan que se sobrescriba elidde la entidad antes de guardar en base de datos.Esta PR soluciona el problema añadiendo al
sqlFileStoreun parámetro opcionalreplace_idque simula el comportamiento de un flujo histórico configurado con unreplaceId. El sqlFileStore genera un id de entidad a partir de los atributos especificados, antes de construir la orden SQL.